chore(ci): bump package version after release via pull request#2239
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa
requested review from
leandrodamascena
and removed request for
a team
boring-cyborg
Bot
added
the
github-actions
pull-request-size
Bot
added
the
size/L
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
I just left a comment about permissions, but for everything else, this looks good!
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
Are these permissions not conflicting with each other? I think the pull-requests: write permission is enough for that, no? The contents: write permission seems to be much broader and allows things we don't need.
References:
https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28#pull-requests
https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28#contents
There was a problem hiding this comment.
Not in this case :)
create-pr action needs to create a temporary branch to push these staged files (pyproject.toml) - hence contents: write. Then, creates a PR against develop using our temporary branch as the HEAD - hence pull-requests: write
pull-request-size
Bot
added
size/M
| bump_version: | ||
| needs: [build, release] | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
| contents: write | |
| contents: write # create-pr action creates a temporary branch |
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
* develop: chore(ci): bump package version after release via pull request (aws-powertools#2239) chore(ci): convert create-pr steps into composite action (aws-powertools#2238) chore(ci): changelog rebuild (aws-powertools#2241) chore(deps-dev): bump aws-cdk from 2.78.0 to 2.79.0 (aws-powertools#2235) docs(batch_processing): snippets split, improved, and lint (aws-powertools#2231) chore(deps-dev): bump mypy from 1.2.0 to 1.3.0 (aws-powertools#2233)
2 participants
Issue number: #2210
DEPENDENCY: #2238
Summary
Use new create-pr action introduced in #2238 to bump package version via PR instead of pushing directly to
developas part of the release.Changes
bump_versionwith scoped permissions to do exactly thatbuildjob as it no longer needs to push todevelopchangelogjob as it's now handled perfectly in every push via PR - introduced in chore(ci): convert create-pr steps into composite action #2238User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.